feat(gui): allow changing workflow access level#4161
Merged
Xiao-zhen-Liu merged 4 commits intoapache:mainfrom Jan 21, 2026
Merged
feat(gui): allow changing workflow access level#4161Xiao-zhen-Liu merged 4 commits intoapache:mainfrom
Xiao-zhen-Liu merged 4 commits intoapache:mainfrom
Conversation
github-actions
bot
added
feature
engine
frontend
Contributor
Author
|
@Xiao-zhen-Liu Can you review this PR please? |
Contributor
|
@seongjinyoon Thanks. Is it possible to add test cases? |
Xiao-zhen-Liu
requested changes
Jan 16, 2026
Contributor
Xiao-zhen-Liu
left a comment
Xiao-zhen-Liu
left a comment
There was a problem hiding this comment.
Left some comments. Please also add some unit tests.
frontend/src/app/dashboard/component/user/share-access/share-access.component.ts
Show resolved
Hide resolved
frontend/src/app/dashboard/component/user/share-access/share-access.component.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
I will add test cases after solving the issue regarding MockTexeraDB. |
Contributor
Author
|
@Xiao-zhen-Liu I have addressed your comments. |
Xiao-zhen-Liu
approved these changes
Jan 21, 2026
Contributor
Xiao-zhen-Liu
left a comment
Xiao-zhen-Liu
left a comment
There was a problem hiding this comment.
LGTM. You can add some test cases as a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Previously, when a user was given access to a workflow, the access level (READ/WRITE) could not be changed directly. Users had to revoke access and re-add with the new level. This PR adds the ability for users with write access to change the access level of other users via a dropdown.
Frontend (
share-access.component.ts/share-access.component.html):hasWriteAccessthat checks write access.changeAccessLevel()method with confirmation warning when a user downgrades their own access from WRITE to READ.Backend (
WorkflowAccessResource.scala):grantAccessendpoint to allow users with WRITE access to modify their own access levelBehavior:
Demo:
Screen.Recording.2026-01-14.at.3.51.53.PM.mov
Any related issues, documentation, discussions?
No
How was this PR tested?
Manually tested.
Was this PR authored or co-authored using generative AI tooling?
Revised with Claude Code.